Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: when branchRollback failed, it will trigger retry of multi-tc. #2113

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

objcoding
Copy link
Contributor

Ⅰ. Describe what this PR did

#2089

@codecov-io
Copy link

codecov-io commented Dec 30, 2019

Codecov Report

Merging #2113 into develop will increase coverage by 0.15%.
The diff coverage is 46.15%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2113      +/-   ##
=============================================
+ Coverage      54.22%   54.38%   +0.15%     
  Complexity      2461     2461              
=============================================
  Files            445      445              
  Lines          14858    14861       +3     
  Branches        1734     1764      +30     
=============================================
+ Hits            8057     8082      +25     
- Misses          6001     6002       +1     
+ Partials         800      777      -23
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 47.65% <40%> (-0.38%) 28 <0> (ø)
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.92% <66.66%> (+0.47%) 21 <0> (ø) ⬇️
...buf/convertor/BranchRollbackResponseConvertor.java 100% <0%> (+2.94%) 3% <0%> (ø) ⬇️
...tobuf/convertor/BranchCommitResponseConvertor.java 100% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...buf/convertor/GlobalRollbackResponseConvertor.java 100% <0%> (+3.22%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalCommitResponseConvertor.java 100% <0%> (+3.33%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalStatusResponseConvertor.java 100% <0%> (+3.33%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterTMResponseConvertor.java 82.75% <0%> (+3.44%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterRMResponseConvertor.java 82.75% <0%> (+3.44%) 3% <0%> (ø) ⬇️
...uf/convertor/GlobalLockQueryResponseConvertor.java 100% <0%> (+3.84%) 3% <0%> (ø) ⬇️
... and 13 more

@zjinlei zjinlei changed the title bugfix: (issue#2089)when branchRollback failed, it will trigger retry of multi-tc. bugfix: when branchRollback failed, it will trigger retry of multi-tc. Dec 31, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added Do Not Merge Do not merge into develop and removed Do Not Merge Do not merge into develop labels Jan 3, 2020
@zjinlei zjinlei merged commit 9257420 into apache:develop Jan 6, 2020
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Jan 14, 2020
* 'develop' of https://github.com/seata/seata: (125 commits)
  optimize: tcc module code style (apache#2103)
  refactor: change the package path of MySQL recognizer (apache#2125)
  optimize: fix query typo (apache#2176)
  refactor: add sql parser type druid as constant (apache#2156)
  test: enhance test coverage of seata common (apache#2170)
  optimize: gracefully close resources (apache#2139)
  Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151)
  chore:use serializer instead of codec (apache#2097)
  optimize: spring module code style (apache#2159)
  optimize: Add Dubbo compatibility (apache#2036)
  optimize : seata-rm-datasource module code style (apache#2062)
  bugfix: Saga report branch status incorrect when service retried succeed (apache#2145)
  optimize:optimize log specifications (apache#2146)
  bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113)
  refactor: create sql parser spi and a druid type sql parser (apache#1703)
  refactor: simplify to make seata-common more readable (apache#2038)
  feature: support FastThreadLocalContextCore (apache#2106)
  optimize: some typos (apache#2120)
  optimize: increase the oracle table meta cache code coverage (apache#2078)
  optimize: some typos (apache#2115)
  ...

# Conflicts:
#	pom.xml
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants