Fix issue that a DB file maybe deleted if its polling.url points to a…#16
Fix issue that a DB file maybe deleted if its polling.url points to a…#16weifensh wants to merge 1 commit intoapache:1.7.xfrom
Conversation
… file with old timestamp, double commit to 1.7.x
|
Do we really think this warrants a commit to 1.7.x and a subsequent 1.7.1 release? I am thinking no; I am thinking we can just commit to master and get this included in the next release. |
|
+1 on Dave's comment. |
|
Thanks Dave and Trevor. From my tests, a DB file may be deleted if its polling.url points to a file with old timestamps; Or when TR reboots, DB file might also be deleted (because the url is now an old file comparing to the local one); But this does not appear to affect TR service, as the DB in memory is still there, so it is just the file under /opt/traffic_router/db/ being deleted. So it appears that the affect of the issue is not big, but the files under /opt/traffic_router/db/ do look abnormal. It would be better if 1.7.x could include the fix. But if it needs a lot of efforts, not including it will not affect TR functionalities. |
|
I think it is best to just include this in 1.8 and not worry about 1.7 |
|
@weifensh we decided that it is best to not worry about merging this into 1.7.x. Can you please close this PR? |
Adding changes for use_ims flag
* removed codecov * fix conflicts
3 participants
Fix an issue that a DB file maybe deleted if its polling.url points to a file with old timestamps (double commit this to 1.7.x).