Skip to content

[INLONG-10360][Manager] Combine schedule state transition with group operations - #10445

Merged
dockerzhang merged 9 commits into
apache:dev-offline-syncfrom
aloyszhang:gs
Jun 19, 2024
Merged

[INLONG-10360][Manager] Combine schedule state transition with group operations#10445
dockerzhang merged 9 commits into
apache:dev-offline-syncfrom
aloyszhang:gs

Conversation

@aloyszhang

@aloyszhang aloyszhang commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

Fixes #10360

Motivation

Combine schedule state transition with group operations. details see description in #10360
The finite state machine for schedule :
image

This is the transient status of the schedule info.
With specified operations, the status will change to corresponding value.

Status Operation
NEW inlong group created with schedule info
APPROVED the new inlong group approved by admin
REGISTERED schedule info registered to schedule engine
UPDATED update schedule info for a group
DELETED delete a group

Modifications

  1. add schedule info in InlongGroupRequest
  2. add configuration inlong.schedule.engine to indicate the schedule engine type
  3. replace the implementation QuartzOfflineSyncJob with the interface Job when building quartz job
  4. add ScheduleOperator to process all the schedule related operations
  5. register schedule info to schedule engine after group approved
  6. save schedule info when group created
  7. update schedule info to schedule engine when group updated
  8. delete schedule info when group deleted

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (no)

@aloyszhang aloyszhang self-assigned this Jun 18, 2024
…manager/common/enums/ScheduleStatus.java

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>

@EMsnap EMsnap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the fsm looks great

@aloyszhang

Copy link
Copy Markdown
Contributor Author

I resolved your comments, PTAL again @fuweng11

@dockerzhang
dockerzhang merged commit b2350e1 into apache:dev-offline-sync Jun 19, 2024
aloyszhang added a commit that referenced this pull request Jun 20, 2024
…operations (#10445)

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>
@aloyszhang
aloyszhang deleted the gs branch June 22, 2024 06:09
aloyszhang added a commit that referenced this pull request Jun 22, 2024
…operations (#10445)

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>
aloyszhang added a commit that referenced this pull request Jun 25, 2024
…operations (#10445)

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>
aloyszhang added a commit to aloyszhang/inlong that referenced this pull request Jul 9, 2024
…operations (apache#10445)

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>
aloyszhang added a commit that referenced this pull request Jul 9, 2024
…operations (#10445)

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>
aloyszhang added a commit to aloyszhang/inlong that referenced this pull request Jul 9, 2024
…operations (apache#10445)

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>
aloyszhang added a commit that referenced this pull request Jul 9, 2024
…operations (#10445)

Co-authored-by: fuweng11 <76141879+fuweng11@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants