[INLONG-4735][Sort] Add precision support for DecimalFormatInfo, TimeFormatInfo - #4736
Merged
Conversation
healchow
reviewed
Jun 22, 2022
healchow
approved these changes
Jun 22, 2022
Oneal65
approved these changes
Jun 22, 2022
gong
approved these changes
Jun 22, 2022
Contributor
|
@yunqingmoswu please add some ut to cover this PR. |
thesumery
approved these changes
Jun 22, 2022
dockerzhang
approved these changes
Jun 22, 2022
vernedeng
pushed a commit
to vernedeng/incubator-inlong
that referenced
this pull request
Jul 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Fixes #4735
Motivation
Add precision support for DecimalFormatInfo, TimeFormatInfo
Modifications
The precision configuration of DecimalFormatInfo, TimeFormatInfo will be supported.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation