[INLONG-5052][Manager] The workflow that failed to execute still failed, but returned success#5053
Merged
dockerzhang merged 3 commits intoapache:masterfrom Jul 15, 2022
Merged
Conversation
…ed, but returned success
healchow
approved these changes
Jul 14, 2022
kipshi
approved these changes
Jul 14, 2022
healchow
reviewed
Jul 14, 2022
...ger-workflow/src/main/java/org/apache/inlong/manager/workflow/core/impl/TaskServiceImpl.java
Show resolved
Hide resolved
dockerzhang
approved these changes
Jul 15, 2022
bruceneenhl
pushed a commit
to bruceneenhl/inlong
that referenced
this pull request
Aug 12, 2022
…ed, but returned success (apache#5053)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Ensure that the re executed workflow will no longer behave as successful execution and go to the next step in the case of failure
Modifications
Add listeners for workflowtask on the interface where you click execute again
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
Documentation