Skip to content

[INLONG-5052][Manager] The workflow that failed to execute still failed, but returned success #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dockerzhang merged 3 commits into from
Jul 15, 2022
Merged

[INLONG-5052][Manager] The workflow that failed to execute still failed, but returned success #5053

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48408f0
[INLONG-5052][Manager] The workflow that failed to execute still fail…
fuweng11 Jul 14, 2022
2c78fd1
[INLONG-5052][Manager] Import class
fuweng11 Jul 14, 2022
6e27f0c
[INLONG-5052][Manager] Fix error in TaskServiceImpl
fuweng11 Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...-workflow/src/main/java/org/apache/inlong/manager/workflow/core/impl/TaskServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.inlong.manager.workflow.core.ProcessorExecutor;
import org.apache.inlong.manager.workflow.core.TaskService;
import org.apache.inlong.manager.workflow.core.WorkflowContextBuilder;
import org.apache.inlong.manager.workflow.definition.ServiceTask;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;

Expand Down Expand Up @@ -67,6 +68,8 @@ public WorkflowContext transfer(Integer taskId, String remark, List<String> to,
public WorkflowContext complete(Integer taskId, String remark, String operator) {
WorkflowContext context = workflowContextBuilder
.buildContextForTask(taskId, WorkflowAction.COMPLETE, remark, operator);
ServiceTask serviceTask = (ServiceTask) context.getActionContext().getTask();
serviceTask.initListeners(context);
processorExecutor.executeComplete(context.getActionContext().getTask(), context);
return context;
}
Expand Down