Skip to content

[INLONG-4958][Agent] Unify the exposed metrics for the Agent - #5301

Merged
dockerzhang merged 8 commits into
apache:masterfrom
Greedyu:feature-unify_the_exposed_metrics_for_gent
Aug 2, 2022
Merged

[INLONG-4958][Agent] Unify the exposed metrics for the Agent#5301
dockerzhang merged 8 commits into
apache:masterfrom
Greedyu:feature-unify_the_exposed_metrics_for_gent

Conversation

@Greedyu

@Greedyu Greedyu commented Jul 31, 2022

Copy link
Copy Markdown
Contributor

Feature unify the exposed metrics for Agent

Motivation

  1. Metric related classes are migrated to the agent-common module
  2. Change the isPrometheusEnabled() method to create the indicator processing method and change it to the class name specification
  3. Abstraction indicator processing

Greedyu added 2 commits July 31, 2022 21:48
2. Change the isPrometheusEnabled() method to create the indicator processing method and change it to the class name specification
3. Abstraction metric processing
2. Change the isPrometheusEnabled() method to create the indicator processing method and change it to the class name specification
3. Abstraction metric processing
@healchow healchow changed the title [INLONG-4958][Agent] Feature unify the exposed metrics for Agent [INLONG-4958][Agent] Unify the exposed metrics for the Agent Jul 31, 2022
@dockerzhang

Copy link
Copy Markdown
Contributor

@luchunliang @pocozh PTAL, thanks.

Comment thread inlong-agent/conf/agent.properties Outdated
Comment thread inlong-agent/conf/agent.properties Outdated
Comment thread inlong-agent/conf/agent.properties Outdated

@luchunliang luchunliang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

2. AgentConstants.GLOBAL_METRICS
3. Modify the name of the Metric processing class

@pocozh pocozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread inlong-agent/conf/agent.properties
Comment thread inlong-agent/conf/agent.properties
2. Rollback agent.properties file configuration interval to increase readability
@dockerzhang
dockerzhang merged commit b740fdd into apache:master Aug 2, 2022
bruceneenhl pushed a commit to bruceneenhl/inlong that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Unify the Exposed Metrics for Agent

5 participants