[INLONG-8180][Agent] Improve the efficiency and safety of log file reading - #8182
Merged
Conversation
…eading 1、limit the length of one time reading，avoid oom 2、read multi lines one time to reduce io
dockerzhang
changed the title
Contributor
|
Please rebase from the master to solve the failed UT. |
…eading fix ut error
healchow
reviewed
Jun 8, 2023
healchow
reviewed
Jun 8, 2023
healchow
changed the title
…eading fix ut error
…eading fit ut error
…eading fix ut error
…eading fix according to the code review
healchow
approved these changes
Jun 12, 2023
EMsnap
reviewed
Jun 12, 2023
…eading fix the typo
…eading fix according to the code review
doleyzi
approved these changes
Jun 13, 2023
EMsnap
approved these changes
Jun 13, 2023
dockerzhang
approved these changes
Jun 13, 2023
…eading fix ut error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
[INLONG-8180][Agent] improve the efficiency and safety for log file reading
Motivation
case the agent oom when it meets one line that was 1G long；the agent take most cpu just to read the file
Modifications
1、limit the length of one time reading，avoid oom
2、read multi lines one time to reduce io
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation