Pipe: fix losing points when enable batch mode introduced by progress commit framework refactor#11722
Merged
SteveYurongSu merged 4 commits intoapache:masterfrom Dec 19, 2023
Merged
Conversation
Collaborator
|
LGTM. The reason is that one connector may transfer events from multiple dataregions, and events from different dataregions may have the same commit id. So we should use equals() instead of comparing commit ids. |
SteveYurongSu
approved these changes
Dec 18, 2023
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
… commit framework refactor (apache#11722) With the introduction of `PipeEventCommitter`, each DR assigns commit id independently to events. Events with the same commit id in different DRs may be lost if using commit id as a condition for duplication check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As title. With the introduction of
PipeEventCommitter, each DR assigns commit id independently to events. Events with the same commit id in different DRs may be lost if using commit id as a condition for duplication check.This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR