Skip to content

Pipe: fix losing points when enable batch mode introduced by progress commit framework refactor #11722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveYurongSu merged 4 commits into from
Dec 19, 2023
Merged

Pipe: fix losing points when enable batch mode introduced by progress commit framework refactor #11722

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b6f2ca
fix: batch mode offer event
VGalaxies Dec 14, 2023
256e2f5
fix: remove batch mode offer event duplication check
VGalaxies Dec 15, 2023
2c8622a
Revert "fix: remove batch mode offer event duplication check"
VGalaxies Dec 18, 2023
5e58979
chore: add comments
VGalaxies Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...apache/iotdb/db/pipe/connector/payload/evolvable/builder/PipeTransferBatchReqBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,9 @@ public boolean onEvent(TabletInsertionEvent event) throws IOException, WALPipeEx
final TPipeTransferReq req = buildTabletInsertionReq(event);
final long requestCommitId = ((EnrichedEvent) event).getCommitId();

if (requestCommitIds.isEmpty()
|| !requestCommitIds.get(requestCommitIds.size() - 1).equals(requestCommitId)) {
// The deduplication logic here is to avoid the accumulation of the same event in a batch when
// retrying.
if ((events.isEmpty() || !events.get(events.size() - 1).equals(event))) {
reqs.add(req);
events.add(event);
requestCommitIds.add(requestCommitId);
Expand Down