Skip to content

Pipe: Prevent duplicate error logging in AsyncPipeDataTransferServiceClient #16856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 2 commits into from
Dec 4, 2025
Merged

Pipe: Prevent duplicate error logging in AsyncPipeDataTransferServiceClient #16856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6f2749
Fix: Prevent duplicate error logging in AsyncPipeDataTransferServiceC…
luoluoyuyu Dec 3, 2025
c46036c
update
luoluoyuyu Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...apache/iotdb/db/pipe/sink/protocol/thrift/async/handler/PipeTransferTrackableHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public void onComplete(final TPipeTransferResp response) {
public void onError(final Exception exception) {
if (client != null) {
ThriftClient.resolveException(exception, client);
client.setPrintLogWhenEncounterException(false);
}

if (connector.isClosed()) {
Expand Down
7 changes: 6 additions & 1 deletion ...c/main/java/org/apache/iotdb/commons/client/async/AsyncPipeDataTransferServiceClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class AsyncPipeDataTransferServiceClient extends IClientRPCService.AsyncC
private static final AtomicInteger idGenerator = new AtomicInteger(0);
private final int id = idGenerator.incrementAndGet();

private final boolean printLogWhenEncounterException;
private boolean printLogWhenEncounterException;

private final TEndPoint endpoint;
private final ClientManager<TEndPoint, AsyncPipeDataTransferServiceClient> clientManager;
Expand Down Expand Up @@ -85,6 +85,7 @@ public void onComplete() {
public void onError(final Exception e) {
super.onError(e);
ThriftClient.resolveException(e, this);
setPrintLogWhenEncounterException(false);
returnSelf(
(i) -> i instanceof IllegalStateException && "Client has an error!".equals(i.getMessage()));
}
Expand All @@ -106,6 +107,10 @@ public boolean printLogWhenEncounterException() {
return printLogWhenEncounterException;
}

public void setPrintLogWhenEncounterException(final boolean printLogWhenEncounterException) {
this.printLogWhenEncounterException = printLogWhenEncounterException;
}

/**
* return self, the method doesn't need to be called by the user and will be triggered after the
* RPC is finished.
Expand Down