Skip to content

Pipe: Fixed the auth judgement NPE & Reduced the log in InsertTabletStatement #16859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 1 commit into from
Dec 4, 2025
Merged

Pipe: Fixed the auth judgement NPE & Reduced the log in InsertTabletStatement #16859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .../main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
package org.apache.iotdb.db.queryengine.plan.statement.crud;

import org.apache.iotdb.common.rpc.thrift.TTimePartitionSlot;
import org.apache.iotdb.commons.conf.CommonDescriptor;
import org.apache.iotdb.commons.exception.MetadataException;
import org.apache.iotdb.commons.path.PartialPath;
import org.apache.iotdb.commons.schema.table.column.TsTableColumnCategory;
Expand Down Expand Up @@ -702,11 +703,15 @@ protected void subRemoveAttributeColumns(List<Integer> columnsToKeep) {

@Override
public String toString() {
final int size = CommonDescriptor.getInstance().getConfig().getPathLogMaxSize();
return "InsertTabletStatement{"
+ "deviceIDs="
+ Arrays.toString(deviceIDs)
+ ", measurements="
+ Arrays.toString(measurements)
+ Arrays.toString(
Objects.nonNull(measurements) && measurements.length > size
? Arrays.copyOf(measurements, size)
: measurements)
+ ", rowCount="
+ rowCount
+ ", timeRange=["
Expand Down
6 changes: 4 additions & 2 deletions ...mmons/src/main/java/org/apache/iotdb/commons/pipe/receiver/PipeReceiverStatusHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.annotation.Nullable;

import java.util.Arrays;
import java.util.Collections;
import java.util.List;
Expand Down Expand Up @@ -106,7 +108,7 @@ public void handle(
*/
public void handle(
final TSStatus status,
final String exceptionMessage,
final @Nullable String exceptionMessage,
final String recordMessage,
final boolean log4NoPrivileges) {

Expand Down Expand Up @@ -206,7 +208,7 @@ public void handle(
break;
default:
// Some auth error may be wrapped in other codes
if (exceptionMessage.contains(NO_PERMISSION_STR)) {
if (Objects.nonNull(exceptionMessage) && exceptionMessage.contains(NO_PERMISSION_STR)) {
if (skipIfNoPrivileges) {
if (log4NoPrivileges && LOGGER.isWarnEnabled()) {
LOGGER.warn(
Expand Down
Loading