Fix REST table metric statement type labels

[HTHou]

Description

This PR avoids recording full table-model AST strings in REST table v1 query metric labels.

The REST table v1 query endpoint previously passed Statement#toString() as the type label to performance_overview, which could expose long query text such as Query{queryBody=...} and produce unstable/high-cardinality labels.

The change records QUERY for the query endpoint instead. For REST table v1 non-query, this PR removes the separate EXECUTE_NON_QUERY_PLAN metric recording to keep it aligned with the RPC SQL statement path, which does not use a separate SQL non-query metric interface.

I also checked other CommonUtils.addStatementExecutionLatency call sites and did not find remaining toString() usage for metric type labels.

Verification

./mvnw -pl external-service-impl/rest -am -DskipTests -DskipITs compile

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

This PR adjusts REST table v1 statement-latency metric labeling to avoid recording full table-model AST strings (high cardinality / potentially long query text) in performance_overview tags.

Changes:

• Record a stable metric Tag.TYPE value (QUERY) for the REST table v1 query endpoint instead of Statement#toString().
• Remove the REST table v1 non-query EXECUTE_NON_QUERY_PLAN latency metric emission.

Comments suppressed due to low confidence (1)

external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/table/v1/impl/RestApiServiceImpl.java:239

• executeNonQueryStatement no longer records performance_overview latency (the previous addStatementExecutionLatency(OperationType.EXECUTE_NON_QUERY_PLAN, …) timing block was removed). This is an observability regression: REST table v1 non-query calls will stop appearing in this metric while other REST implementations still emit EXECUTE_NON_QUERY_PLAN timers. Consider keeping the timer and switching the label to a stable, low-cardinality value (e.g., a constant like StatementType.NULL.name()/"NON_QUERY", or a bounded mapping based on statement.getClass()), instead of dropping it entirely.

    } finally {
      if (queryId != null) {
        COORDINATOR.cleanupQueryExecution(queryId);
      }
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.