Skip to content

Fix REST table metric statement type labels #17757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HTHou merged 1 commit into from
May 25, 2026
+2 −8
Merged

Fix REST table metric statement type labels #17757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...l/rest/src/main/java/org/apache/iotdb/rest/protocol/table/v1/impl/RestApiServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.apache.iotdb.db.queryengine.plan.relational.metadata.Metadata;
import org.apache.iotdb.db.queryengine.plan.relational.sql.ast.Insert;
import org.apache.iotdb.db.queryengine.plan.relational.sql.parser.SqlParser;
import org.apache.iotdb.db.queryengine.plan.statement.StatementType;
import org.apache.iotdb.db.queryengine.plan.statement.crud.InsertTabletStatement;
import org.apache.iotdb.db.utils.CommonUtils;
import org.apache.iotdb.db.utils.SetThreadName;
Expand Down Expand Up @@ -139,7 +140,7 @@ public Response executeQueryStatement(SQL sql, SecurityContext securityContext)
.ifPresent(
s ->
CommonUtils.addStatementExecutionLatency(
OperationType.EXECUTE_QUERY_STATEMENT, s.toString(), costTime));
OperationType.EXECUTE_QUERY_STATEMENT, StatementType.QUERY.name(), costTime));
}
}

Expand Down Expand Up @@ -194,7 +195,6 @@ public Response executeNonQueryStatement(SQL sql, SecurityContext securityContex
SqlParser relationSqlParser = new SqlParser();
Long queryId = null;
Statement statement = null;
long startTime = System.nanoTime();
try {
IClientSession clientSession = SESSION_MANAGER.getCurrSession();
statement = createStatement(sql, clientSession, relationSqlParser);
Expand Down Expand Up @@ -233,12 +233,6 @@ public Response executeNonQueryStatement(SQL sql, SecurityContext securityContex
} catch (Exception e) {
return Response.ok().entity(ExceptionHandler.tryCatchException(e)).build();
} finally {
long costTime = System.nanoTime() - startTime;
Optional.ofNullable(statement)
.ifPresent(
s ->
CommonUtils.addStatementExecutionLatency(
OperationType.EXECUTE_NON_QUERY_PLAN, s.toString(), costTime));
if (queryId != null) {
COORDINATOR.cleanupQueryExecution(queryId);
}
Expand Down
Loading