Skip to content

Limit delete predicate DNF expansion#18148

Closed
Caideyipi wants to merge 1 commit into
masterfrom
fix-delete-dnf-limit
Closed

Limit delete predicate DNF expansion#18148
Caideyipi wants to merge 1 commit into
masterfrom
fix-delete-dnf-limit

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

  • Bound table delete predicate DNF expansion to 1000 disjunctive terms.
  • Return a localized semantic error instead of building an unbounded expression cross product.
  • Add focused unit coverage for within-limit and limit-exceeded DNF expansion.

Tests

  • mvn spotless:apply -pl iotdb-core/datanode
  • git diff --check
  • python -c "... DataNodeQueryMessages i18n parity ..."
  • mvn test -pl iotdb-core/datanode -Dtest=AnalyzeUtilsTest failed before tests: JVM native memory allocation failure during checkstyle.
  • mvn test -pl iotdb-core/datanode -Dtest=AnalyzeUtilsTest "-Dcheckstyle.skip=true" "-Dspotless.check.skip=true" failed during datanode compile in generated aggregation classes: missing ComparatorChain / getModeMapSizeThreshold().

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.89%. Comparing base (e44cbbb) to head (0dd9b6d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18148      +/-   ##
============================================
+ Coverage     41.87%   41.89%   +0.02%     
  Complexity      318      318              
============================================
  Files          5297     5297              
  Lines        374093   374179      +86     
  Branches      48287    48302      +15     
============================================
+ Hits         156645   156770     +125     
+ Misses       217448   217409      -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi Caideyipi closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant