Skip to content

[to dev/1.3] Remove incorrect timeout reassignment after query planning#18196

Open
shuwenwei wants to merge 1 commit into
dev/1.3from
fix/remove_timeout_reassignment_after_planning_in_QueryExecution
Open

[to dev/1.3] Remove incorrect timeout reassignment after query planning#18196
shuwenwei wants to merge 1 commit into
dev/1.3from
fix/remove_timeout_reassignment_after_planning_in_QueryExecution

Conversation

@shuwenwei

@shuwenwei shuwenwei commented Jul 13, 2026

Copy link
Copy Markdown
Member

The context.setTimeOut() call in QueryExecution.start() mutated timeOut from the total timeout duration to the remaining time after planning. However, all consumers (checkTimeOutForQuery, cleanUpStaleQueries, timeout exception messages) assume timeOut holds the total duration. This caused stale query cleanup to trigger earlier than expected and incorrect deadline values in timeout error messages.

This was already fixed on the master branch by commit fddf0a6 as part of #15031.

The context.setTimeOut() call in QueryExecution.start() mutated timeOut
from the total timeout duration to the remaining time after planning.
However, all consumers (checkTimeOutForQuery, cleanUpStaleQueries,
timeout exception messages) assume timeOut holds the total duration.
This caused stale query cleanup to trigger earlier than expected and
incorrect deadline values in timeout error messages.
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.50%. Comparing base (458b547) to head (9735c37).
⚠️ Report is 67 commits behind head on dev/1.3.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #18196      +/-   ##
=============================================
+ Coverage      42.61%   43.50%   +0.89%     
+ Complexity       241      198      -43     
=============================================
  Files           3622     3630       +8     
  Lines         240790   243739    +2949     
  Branches       29341    29741     +400     
=============================================
+ Hits          102602   106030    +3428     
+ Misses        138188   137709     -479     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant