Skip to content

[Pipe] Reduce AirGap sink reconnect log noise - #18243

Merged
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix/pipe-air-gap-log-noise
Jul 20, 2026
Merged

[Pipe] Reduce AirGap sink reconnect log noise#18243
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix/pipe-air-gap-log-noise

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

When an AirGap sink establishes a TCP connection but the application handshake fails, one retry cycle can emit multiple WARN logs with duplicate stack traces. In a tight reconnect loop, the TCP connection INFO log and repeated handshake warnings can dominate log_datanode_all.log.

Changes

  • Restore LoggerPeriodicalLogReducer as the default PipeLogger implementation. The shared-reducer refactor removed the DataNode-side injection but left the default implementation formatting logs without rate limiting.
  • Log retryable connection and handshake failures as rate-limited root-cause summaries instead of repeated stack traces.
  • Keep the full throwable on the final task-stopping warning for diagnosis.
  • Downgrade the TCP-only connection success message from INFO to DEBUG because the application handshake may still fail.
  • Format handshake failures with a stable remote endpoint instead of the socket's ephemeral local port, allowing duplicate messages to share a rate-limit key.
  • Update both English and Chinese messages and make PipeLoggerTest exercise the default logger path.

Verification

  • mvn -o -pl iotdb-core/node-commons -Dtest=PipeLoggerTest,LoggerPeriodicalLogReducerTest test
  • mvn -o -pl iotdb-core/node-commons -P with-zh-locale -DskipTests test-compile
  • mvn -o -pl iotdb-core/node-commons spotless:apply

This PR has:

  • been self-reviewed.
  • added or updated unit tests for the changed behavior.
  • been compiled with both English and Chinese locales.

Key changed classes
  • PipeLogger
  • PipeAbstractSinkSubtask
  • IoTDBAirGapSink
  • PipeLoggerTest

@jt2594838
jt2594838 merged commit 1b44799 into apache:master Jul 20, 2026
41 checks passed
@jt2594838
jt2594838 deleted the fix/pipe-air-gap-log-noise branch July 20, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants