[Subscription] Fix consensus subscription metrics across Regions#18277
Merged
jt2594838 merged 1 commit intoJul 22, 2026
Merged
Conversation
jt2594838
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Isolate consensus subscription metrics by Region
Consensus subscription queues from different Regions can share the same consumer-group/topic queue ID. The metrics singleton previously keyed queues and rates only by that ID, so one Region overwrote or hid the others.
This change keys metric state by (queue ID, Region ID), adds the region tag to every consensus-subscription metric, passes the Region when marking transfer rates, and removes only the matching Region's gauges and rate. Metric lifecycle operations are serialized and stale queue instances cannot deregister the active instance for the same key.
Make catch-up status observable and accurate
For a stopped workload, an initialized active Region with zero lag now means the queue has no buffered, in-flight, pending, lingered, or unread WAL work.
Verification
This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR