Skip to content

Preserve Pipe sink exception root causes - #18335

Merged
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix/pipe-sink-exception-cause
Jul 29, 2026
Merged

Preserve Pipe sink exception root causes#18335
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix/pipe-sink-exception-cause

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Preserve diagnostic information

  • Use Throwable.toString() for root-cause reporting so exceptions with a null message still include their exception type.
  • Preserve the original throwable as the cause of PipeRuntimeSinkCriticalException instances.
  • Add cause-aware constructors to the Pipe runtime exception hierarchy.

Test coverage

  • Add unit coverage for null root-cause messages.
  • Add unit coverage verifying that failure reporting preserves the original cause chain.

Testing

Not run locally because the machine does not have enough memory; CI will validate the change.


This PR has:

  • been self-reviewed.
  • added or modified unit tests to cover the new code paths.

Key changed/added classes (or packages if there are too many classes) in this PR
  • PipeAbstractSinkSubtask
  • PipeSinkSubtask
  • PipeRuntimeException and its critical sink subclasses
  • PipeSinkSubtaskTest

@jt2594838
jt2594838 merged commit 8d5da83 into apache:master Jul 29, 2026
40 of 41 checks passed
@jt2594838
jt2594838 deleted the fix/pipe-sink-exception-cause branch July 29, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants