Fix corrupted TsFile IT file selection - #18346
Merged
jt2594838 merged 1 commit intoJul 29, 2026
Merged
Conversation
Limit the corrupted file lookup to the test database and consume the full query result so corruption detected during later fetches is surfaced.
shuwenwei
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
testNormalQueryWithCorruptedChunkDataOrPageReadersearched the entire DataNodedata/sequencetree for the first TsFile. If another database had already created a TsFile, the test could corrupt that unrelated file and then incorrectly report that the target query succeeded.The test also only called
Statement.execute, so an exception raised while fetching a later result block could be missed.Changes
executeQueryand consume the full result set so delayed corruption errors are surfaced.Verification
mvn spotless:apply -pl integration-test -P with-integration-testsmvn test-compile -pl integration-test -P with-integration-tests -DskipTestsgit diff --checkThis PR has:
Key changed/added classes
IoTDBQueryWithCorruptedTsFileIT