[Performance] Restore aligned memtable flush fast path - #18406
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18406 +/- ##
============================================
- Coverage 43.50% 43.33% -0.17%
Complexity 374 374
============================================
Files 5395 5395
Lines 385520 385608 +88
Branches 50160 50185 +25
============================================
- Hits 167715 167114 -601
- Misses 217805 218494 +689 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The aligned memtable flush fix in f87c9c3e80c introduced active-column mapping into the common path even when no measurement was deleted. Wide aligned batches then pay for Integer column mappings and additional per-point branches during encoding.
This change keeps the deleted-measurement encoding path unchanged and dispatches to the pre-f87c9c3 tight loop only when the active schema is the original schema. Flushing memtables are immutable, so the identity check is stable throughout encoding.
Two focused unit tests verify that:
Tests