Skip to content

[To dev/1.3] Update thrift to 0.23.0 - #18446

Merged
HTHou merged 2 commits into
dev/1.3from
codex/upgrade-thrift-0.23.0-dev-1.3
Aug 12, 2026
Merged

[To dev/1.3] Update thrift to 0.23.0#18446
HTHou merged 2 commits into
dev/1.3from
codex/upgrade-thrift-0.23.0-dev-1.3

Conversation

@HTHou

@HTHou HTHou commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Backport the Thrift 0.23.0 upgrade from master (#17945) to dev/1.3.

  • bump the Thrift runtime and bundled compiler to 0.23.0
  • update the binary license inventory and JDBC feature bundle
  • exclude unused HTTP, Jakarta, and partial-deserialization transitive dependencies
  • return a reusable non-null ServerContext from Thrift server event handlers for 0.23 compatibility
  • update the test RPC handler and add coverage for the no-op context
  • declare the integration-test HTTP client dependencies explicitly after the Thrift transitive dependency change

This backport intentionally does not change the C++ client or C++ workflows.

Impact

Java clients and server components on dev/1.3 now build and run against Thrift 0.23.0 while preserving the Java 8 and javax dependency baseline.

Validation

  • ./mvnw spotless:apply -pl iotdb-client/service-rpc,iotdb-core/node-commons,iotdb-core/confignode,iotdb-core/consensus,iotdb-core/datanode
  • ./mvnw spotless:apply -pl integration-test -P with-integration-tests
  • ./mvnw test-compile -DskipTests -pl integration-test -am -P with-integration-tests (31/31 reactor modules succeeded; all 476 integration-test sources compiled)
  • ./mvnw test-compile -DskipTests (all Thrift generation and affected Java modules compiled successfully; the reactor later stopped in distribution because test-compile does not produce its required local server/CLI/ConfigNode ZIP artifacts)
  • ./mvnw -pl iotdb-core/node-commons -am -Dtest=NoopServerContextTest -Dsurefire.failIfNoSpecifiedTests=false test
  • verified iotdb-thrift-commons resolves only org.apache.thrift:libthrift:0.23.0 from the inspected Thrift dependency set

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.44%. Comparing base (e0ae0bd) to head (d3ce46a).
⚠️ Report is 29 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...tocol/thrift/handler/BaseServerContextHandler.java 0.00% 3 Missing ⚠️
...de/service/thrift/ConfigNodeRPCServiceHandler.java 0.00% 1 Missing ⚠️
...s/pipe/service/PipeConsensusRPCServiceHandler.java 0.00% 1 Missing ⚠️
...l/thrift/handler/InternalServiceThriftHandler.java 0.00% 1 Missing ⚠️
.../exchange/MPPDataExchangeServiceThriftHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #18446      +/-   ##
=============================================
+ Coverage      43.93%   44.44%   +0.50%     
  Complexity       198      198              
=============================================
  Files           3633     3637       +4     
  Lines         244740   246266    +1526     
  Branches       29901    30227     +326     
=============================================
+ Hits          107526   109442    +1916     
+ Misses        137214   136824     -390     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HTHou
HTHou marked this pull request as ready for review August 12, 2026 02:31
@HTHou
HTHou merged commit 2162b8d into dev/1.3 Aug 12, 2026
23 of 24 checks passed
@HTHou
HTHou deleted the codex/upgrade-thrift-0.23.0-dev-1.3 branch August 12, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant