[To dev/1.3] Update thrift to 0.23.0 - #18446
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev/1.3 #18446 +/- ##
=============================================
+ Coverage 43.93% 44.44% +0.50%
Complexity 198 198
=============================================
Files 3633 3637 +4
Lines 244740 246266 +1526
Branches 29901 30227 +326
=============================================
+ Hits 107526 109442 +1916
+ Misses 137214 136824 -390 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport the Thrift 0.23.0 upgrade from master (#17945) to
dev/1.3.ServerContextfrom Thrift server event handlers for 0.23 compatibilityThis backport intentionally does not change the C++ client or C++ workflows.
Impact
Java clients and server components on
dev/1.3now build and run against Thrift 0.23.0 while preserving the Java 8 andjavaxdependency baseline.Validation
./mvnw spotless:apply -pl iotdb-client/service-rpc,iotdb-core/node-commons,iotdb-core/confignode,iotdb-core/consensus,iotdb-core/datanode./mvnw spotless:apply -pl integration-test -P with-integration-tests./mvnw test-compile -DskipTests -pl integration-test -am -P with-integration-tests(31/31 reactor modules succeeded; all 476 integration-test sources compiled)./mvnw test-compile -DskipTests(all Thrift generation and affected Java modules compiled successfully; the reactor later stopped indistributionbecausetest-compiledoes not produce its required local server/CLI/ConfigNode ZIP artifacts)./mvnw -pl iotdb-core/node-commons -am -Dtest=NoopServerContextTest -Dsurefire.failIfNoSpecifiedTests=false testiotdb-thrift-commonsresolves onlyorg.apache.thrift:libthrift:0.23.0from the inspected Thrift dependency set