[Pipe] Fix conversion task ID collision after leader switch - #18494
Merged
Caideyipi merged 1 commit intoAug 19, 2026
Conversation
luoluoyuyu
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed
Include each event progress index in the TsFile conversion task identity, even when a committer key is present. Commit IDs are DataNode-local and can repeat after a leader change; omitting the progress index can make two different snapshots look like the same conversion task and cause the receiver to acknowledge the newer file without loading it.
Scope
This task ID is used by sync, async, and air-gap transfer paths. The fix preserves stable IDs for retries of the same progress while separating different historical snapshots.
Tests
The full Maven test lifecycle is currently blocked before test execution by unrelated stale/generated Freemarker compilation errors in the DataNode module.