Skip to content

Fix IoTConsensus reconstruction IT follower synchronization - #18536

Merged
CRZbulabula merged 1 commit into
masterfrom
yongzao/fix-iotv1-follower-sync
Aug 28, 2026
Merged

Fix IoTConsensus reconstruction IT follower synchronization#18536
CRZbulabula merged 1 commit into
masterfrom
yongzao/fix-iotv1-follower-sync

Conversation

@CRZbulabula

@CRZbulabula CRZbulabula commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Motivation

Ensure the IoTConsensus reconstruction IT waits until the follower has received the inserted data before deleting its TsFiles and exercising the reconstruction failure path. The follower is queried through a DataNode-pinned connection, and the tree-model timestamp column is accounted for when validating the two value columns.

Replace the unbounded while (true) polling loops with bounded Awaitility assertions (one-second polling and a one-minute timeout), assert that TsFile deletion succeeds, close temporary query result handles, and retain the reconstruction status check with its ten-minute bound.

Verification

  • mvn spotless:apply -P with-integration-tests -pl integration-test
  • mvn verify -DskipUTs -Dit.test=IoTDBRegionReconstructForIoTV1IT#normal1C3DTest -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -am -PClusterIT -P with-integration-tests

The targeted IT passed with 1 test, 0 failures, and 0 errors.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.06%. Comparing base (a10bc6b) to head (b7976d3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18536      +/-   ##
============================================
- Coverage     42.24%   42.06%   -0.18%     
  Complexity      413      413              
============================================
  Files          5409     5409              
  Lines        389925   389925              
  Branches      50970    50970              
============================================
- Hits         164721   164035     -686     
- Misses       225204   225890     +686     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CRZbulabula
CRZbulabula force-pushed the yongzao/fix-iotv1-follower-sync branch from c885b54 to 697b7d4 Compare August 27, 2026 12:26
@CRZbulabula
CRZbulabula force-pushed the yongzao/fix-iotv1-follower-sync branch from 697b7d4 to b7976d3 Compare August 27, 2026 15:34
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@CRZbulabula
CRZbulabula merged commit 6aec4b8 into master Aug 28, 2026
38 of 41 checks passed
@CRZbulabula
CRZbulabula deleted the yongzao/fix-iotv1-follower-sync branch August 28, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant