[Pipe] Preserve downstream sink error messages - #18553
Merged
Merged
Conversation
jt2594838
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When a pipe sink receives a failure from the downstream node, the returned TSStatus may contain the real receiver error in nested subStatus entries. The sink previously exposed only a generic MULTIPLE_ERROR or pipe wrapper message, so SHOW PIPES.ExceptionMessage did not identify the actual cause.
Design
The status handler recursively inspects nested sub-statuses and prefers a concrete downstream receiver error over generic aggregate or pipe wrapper messages. The selected message is preserved in the prior status and included in asynchronous retry summary exceptions. When the root cause has no message, its exception type is retained.
Stored retry errors are cleared when retry queues are drained, pipe events are discarded, or the sink closes, preventing stale failures from appearing in later status reports.
Tests
This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR