Skip to content

[ISSUE-2905] Fix Files.deleteIfExists() doesn't work for HDFS file #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2021
Merged

[ISSUE-2905] Fix Files.deleteIfExists() doesn't work for HDFS file #2912

merged 2 commits into from
Mar 27, 2021

Conversation

@samperson1997
Copy link
Contributor

@samperson1997 samperson1997 commented Mar 25, 2021

Cluster module introduce Files.deleteIfExists(file.toPath()) in tsfile resource, but toPath() method returns java.nio.file.Path which doesn't work for HDFS file, and result in failure of storing tsfiles in HDFS.

@samperson1997 samperson1997 changed the title Fix Files.deleteIfExists() doesn't work for HDFS file [ISSUE-2095] Fix Files.deleteIfExists() doesn't work for HDFS file Mar 25, 2021
@samperson1997 samperson1997 requested a review from jt2594838 March 25, 2021 15:57
@samperson1997 samperson1997 linked an issue Mar 26, 2021 that may be closed by this pull request
Cannot write data into HDFS #2905
Closed
@samperson1997 samperson1997 mentioned this pull request Mar 26, 2021
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 26, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

@samperson1997 samperson1997 changed the title [ISSUE-2095] Fix Files.deleteIfExists() doesn't work for HDFS file [ISSUE-2905] Fix Files.deleteIfExists() doesn't work for HDFS file Mar 27, 2021
@HTHou HTHou merged commit b28fa65 into master Mar 27, 2021
@HTHou HTHou deleted the hdfs_delete branch March 27, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HTHou HTHou HTHou approved these changes

@jt2594838 jt2594838 Awaiting requested review from jt2594838

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot write data into HDFS

2 participants

@samperson1997 @HTHou