Skip to content

[IOTDB-1259] upgrade libthrift from 0.12.0/0.13.0 to 0.14.1 and updated related classes or files#3163

Merged
neuyilan merged 21 commits intoapache:masterfrom
icloudsong:fix_thrift0.14.1
May 16, 2021
Merged

[IOTDB-1259] upgrade libthrift from 0.12.0/0.13.0 to 0.14.1 and updated related classes or files#3163
neuyilan merged 21 commits intoapache:masterfrom
icloudsong:fix_thrift0.14.1

Conversation

@neuyilan
Copy link
Member

@neuyilan neuyilan commented May 12, 2021

The former related pr is #2935

@neuyilan neuyilan marked this pull request as draft May 12, 2021 02:16
@neuyilan neuyilan marked this pull request as ready for review May 13, 2021 01:04
@neuyilan neuyilan changed the title [TEST] Fix thrift0.14.1 [IOTDB-1259] upgrade libthrift from 0.12.0/0.13.0 to 0.14.1 and updated related classes or files May 13, 2021
@HTHou HTHou linked an issue May 13, 2021 that may be closed by this pull request
@neuyilan
Copy link
Member Author

There are some UT still failed, I'm trying to fix this, if all the UTs are fixed, I'll approve this PR.

neuyilan and others added 3 commits May 13, 2021 22:50
* upgrade to thrift 0.14.1

* fix errors

* add more comments

* remend the thrift tconfiguration doc

* fix the UT in SessionPoolTest

* remove useless logback term

* fix the ClusterInfoServerTest

Co-authored-by: xiangdong huang <sainthxd@gmail.com>
@HTHou HTHou linked an issue May 14, 2021 that may be closed by this pull request
@neuyilan
Copy link
Member Author

The CI[1] failed is due to the 0.14.1 thrift use the OpenSSL lib[3] while the CI's workflow does not install the OpenSSL, It can be fixed in the next PR.
The CI[2] failed is not introduced by this PR, so I'd like to merge this PR and resolved the failed CI in the next PR.
[1] https://github.com/apache/iotdb/pull/3163/checks?check_run_id=2583170722
[2] https://github.com/apache/iotdb/pull/3163/checks?check_run_id=2583171026
[3] https://github.com/apache/thrift/blob/0.14.1/lib/cpp/src/thrift/transport/TWebSocketServer.cpp#L24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

org.apache.thrift.transport.TTransportException: null There is a vulnerability in thrift 0.13.0 ,upgrade recommended

2 participants