Skip to content

[To rel/0.12]Upgrade libthrift from 0.12.0/0.13.0 to 0.14.1 and updated related classes or files#3216

Merged
HTHou merged 14 commits intoapache:rel/0.12from
neuyilan:apache_0.12_for_thrift_0.14
Jun 4, 2021
Merged

[To rel/0.12]Upgrade libthrift from 0.12.0/0.13.0 to 0.14.1 and updated related classes or files#3216
HTHou merged 14 commits intoapache:rel/0.12from
neuyilan:apache_0.12_for_thrift_0.14

Conversation

@neuyilan
Copy link
Member

Cherry-pick the following two PRs
#3163
#3198

neuyilan added 2 commits May 18, 2021 15:19
…t closed properly in SessionPoolTest. (apache#3198)

Fix the CI issue introduced by thrift0.14 and the thrift server is not closed properly in SessionPoolTest.
@neuyilan neuyilan requested a review from HTHou May 18, 2021 07:30
Copy link
Member

@mychaow mychaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HTHou
Copy link
Contributor

HTHou commented May 21, 2021

There is still a test failed....

@neuyilan
Copy link
Member Author

There is still a test failed....

The CI failed is due to the 0.14.1 thrift use the OpenSSL lib while the CI's workflow does not install the OpenSSL.

@HTHou HTHou merged commit 7b085b3 into apache:rel/0.12 Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants