[IOTDB-2687] Base partition policy of data#5464
Merged
qiaojialin merged 19 commits intoapache:masterfrom Apr 11, 2022
Merged
Conversation
CRZbulabula
changed the title
qiaojialin
requested changes
Apr 9, 2022
confignode/src/assembly/resources/conf/iotdb-confignode.properties
Outdated
Show resolved
Hide resolved
| rpcSchemaPartitionInfo.setSchemaRegionDataNodesMap(schemaRegionReplicaSets); | ||
| return rpcSchemaPartitionInfo; | ||
|
|
||
| // resp.setSchemaRegionMap(schemaRegionMap); |
Contributor
Author
There was a problem hiding this comment.
I'm not sure currently. I first update the process of get or create SchemaPartition in ConfigNode. But then the discussion on Friday decides to change interfaces about SchemaPartition. And the PatternTree isn't ready to use for ConfigNode now. So I comment this codes casually. I'll check this codes and support new SchemaPartition interfaces in next PR.
confignode/src/main/java/org/apache/iotdb/confignode/persistence/DataNodeInfoPersistence.java
Outdated
Show resolved
Hide resolved
confignode/src/main/java/org/apache/iotdb/confignode/physical/crud/QueryDataPartitionPlan.java
Outdated
Show resolved
Hide resolved
confignode/src/main/java/org/apache/iotdb/confignode/physical/sys/SetStorageGroupPlan.java
Show resolved
Hide resolved
qiaojialin
approved these changes
Apr 10, 2022
confignode/src/assembly/resources/conf/iotdb-confignode.properties
Outdated
Show resolved
Hide resolved
confignode/src/assembly/resources/conf/iotdb-confignode.properties
Outdated
Show resolved
Hide resolved
confignode/src/assembly/resources/conf/iotdb-confignode.properties
Outdated
Show resolved
Hide resolved
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConf.java
Outdated
Show resolved
Hide resolved
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConf.java
Outdated
Show resolved
Hide resolved
confignode/src/main/java/org/apache/iotdb/confignode/persistence/DataNodeInfoPersistence.java
Outdated
Show resolved
Hide resolved
confignode/src/main/java/org/apache/iotdb/confignode/physical/PhysicalPlanType.java
Show resolved
Hide resolved
confignode/src/main/java/org/apache/iotdb/confignode/physical/crud/CreateRegionsPlan.java
Show resolved
Hide resolved
node-commons/src/main/java/org/apache/iotdb/commons/partition/TimePartitionSlot.java
Outdated
Show resolved
Hide resolved
node-commons/src/main/java/org/apache/iotdb/commons/partition/TimePartitionSlot.java
Outdated
Show resolved
Hide resolved
wangchao316
requested changes
Apr 11, 2022
| // TODO: optimize | ||
| result = new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode()); | ||
| result.setMessage(String.valueOf(dataNodeInfo.getDataNodeInfo(info))); | ||
| } else { |
Member
There was a problem hiding this comment.
Some judgmental and calculation logic can be placed in the manager. Only when certain conditions are met, the logic needs to be pushed down to the consensus layer.
一些判断性的和计算的逻辑可以放在manager中，只有满足一定条件后才需要下推到共识层。这样可以减轻共识层的压力。
Contributor
Author
There was a problem hiding this comment.
The judgment and calculation logic of register DataNode is on ConfigNodeRPCServerProcessor currently. In order not to return a weird TSStatus that blend with configuration parameters underneath the manager layer.
wangchao316
reviewed
Apr 11, 2022
| import java.nio.ByteBuffer; | ||
|
|
||
| public class SeriesPartitionSlot { | ||
| private int deviceGroupId; |
Contributor
Author
There was a problem hiding this comment.
Renamed as slotId.
added 2 commits
April 11, 2022 14:33
qiaojialin
approved these changes
Apr 11, 2022
xinzhongtianxia
pushed a commit
to xinzhongtianxia/iotdb
that referenced
this pull request
Apr 11, 2022
…er_meta * remotes/upstream/master: [IOTDB-2687] Base partition policy of data (apache#5464) [IOTDB-2868] Construct ExchangeOperator in LocalExecutionPlanner (apache#5466) implement serialize and deserialize of SchemaTree (apache#5474) [IOTDB-2559][IOTDB-1840][IOTDB-2215][IOTDB-2216] Persistent Schema Management (apache#4732) [IOTDB-2876] Definition of common thrift struct (apache#5471) # Conflicts: # server/src/main/java/org/apache/iotdb/db/mpp/common/DataRegion.java # server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/LogicalPlanner.java # server/src/test/java/org/apache/iotdb/db/mpp/sql/plan/DistributionPlannerTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates of ConfigNode: