Skip to content

[IOTDB-2868] Construct ExchangeOperator in LocalExecutionPlanner#5466

Merged
xingtanzjr merged 4 commits intomasterfrom
ty-mpp
Apr 11, 2022
Merged

[IOTDB-2868] Construct ExchangeOperator in LocalExecutionPlanner#5466
xingtanzjr merged 4 commits intomasterfrom
ty-mpp

Conversation

@JackieTien97
Copy link
Copy Markdown
Contributor

@JackieTien97 JackieTien97 commented Apr 9, 2022 •
edited
Loading

  1. Construct ExchangeOperator in LocalExecutionPlanner
  2. Add a DataSourceOperator extends SourceOperator and move initQueryDataSource method from SourceOperator to DataSourceOperator because schema query related source operators don't need to initQueryDataSource
  3. add sourceId field in SeriesScanOperator to make its getSourceId() not returning null.
  4. call execDataQueryFragmentInstance of FragmentInstanceManager in DataRegionStateMachine

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 11, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 56.031% when pulling d064dec on ty-mpp into 600ba97 on master.

xingtanzjr
xingtanzjr reviewed Apr 11, 2022
View reviewed changes
server/src/main/java/org/apache/iotdb/db/mpp/operator/source/ExchangeOperator.java Outdated

@Override
public boolean hasNext() {
return sourceHandle.isFinished();
Copy link
Copy Markdown
Contributor

@xingtanzjr xingtanzjr Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be !sourceHandle.isFinished();

Copy link
Copy Markdown
Contributor Author

@JackieTien97 JackieTien97 Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@JackieTien97 JackieTien97 requested a review from xingtanzjr April 11, 2022 05:47
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

3.6% 3.6% Coverage
0.0% 0.0% Duplication

@xingtanzjr xingtanzjr merged commit 9640b41 into master Apr 11, 2022
@JackieTien97 JackieTien97 deleted the ty-mpp branch April 11, 2022 07:30
xinzhongtianxia pushed a commit to xinzhongtianxia/iotdb that referenced this pull request Apr 11, 2022
Merge remote-tracking branch 'remotes/upstream/master' into new_clust…
1cb5da9 
…er_meta

* remotes/upstream/master:
  [IOTDB-2687] Base partition policy of data (apache#5464)
  [IOTDB-2868] Construct ExchangeOperator in LocalExecutionPlanner (apache#5466)
  implement serialize and deserialize of SchemaTree (apache#5474)
  [IOTDB-2559][IOTDB-1840][IOTDB-2215][IOTDB-2216] Persistent Schema Management (apache#4732)
  [IOTDB-2876] Definition of common thrift struct (apache#5471)

# Conflicts:
#	server/src/main/java/org/apache/iotdb/db/mpp/common/DataRegion.java
#	server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/LogicalPlanner.java
#	server/src/test/java/org/apache/iotdb/db/mpp/sql/plan/DistributionPlannerTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xingtanzjr xingtanzjr xingtanzjr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackieTien97 @coveralls @xingtanzjr