OAK-8633: Add warn logs if we add/update a string property larger than 100KB#152
Closed
tihom88 wants to merge 6 commits intoapache:trunkfrom
Closed
OAK-8633: Add warn logs if we add/update a string property larger than 100KB#152tihom88 wants to merge 6 commits intoapache:trunkfrom
tihom88 wants to merge 6 commits intoapache:trunkfrom
Conversation
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.16.0@1863680 13f79535-47bb-0310-9956-ffa450edef68
catholicon
suggested changes
Sep 25, 2019
Contributor
catholicon
left a comment
catholicon
left a comment
There was a problem hiding this comment.
I think we should simply allow config via command line params - that'd significantly reduce the plumbing to move configured value to intended location.
Contributor
Author
|
@catholicon yes we can enable these via command line params and that will reduce plumbing but in my opinion we should only have those params via command line which have major impact over application. The changes presented here are not that that big to have these enabled via commandline params. Also with osgi config framework, we can persist these and we don't have to add command line params each time we restart application. |
Contributor
Author
|
@catholicon suggested changes are incorporated in PR #155 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.