OAK-8633: Add warn logs if we add/update a string property larger than 100KB (Node)#155
Closed
tihom88 wants to merge 4 commits intoapache:trunkfrom
Closed
OAK-8633: Add warn logs if we add/update a string property larger than 100KB (Node)#155tihom88 wants to merge 4 commits intoapache:trunkfrom
tihom88 wants to merge 4 commits intoapache:trunkfrom
Conversation
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.16.0@1863680 13f79535-47bb-0310-9956-ffa450edef68
catholicon
suggested changes
Oct 3, 2019
| int threshold = OakJcrConstants.DEFAULT_WARN_LOG_STRING_SIZE_THRESHOLD_VALUE; | ||
| if (System.getProperty(OakJcrConstants.WARN_LOG_STRING_SIZE_THRESHOLD_KEY) != null | ||
| && !System.getProperty(OakJcrConstants.WARN_LOG_STRING_SIZE_THRESHOLD_KEY).isEmpty()) { | ||
| threshold = Integer.parseInt(System.getProperty(OakJcrConstants.WARN_LOG_STRING_SIZE_THRESHOLD_KEY)); |
Contributor
There was a problem hiding this comment.
Integer#parseInt can throw NumberFormatException which should be caught an handled. But, better yet, it would cleaner to simply use Integer#getInt(String, int).
| package org.apache.jackrabbit.oak.jcr.session; | ||
|
|
||
| public interface OakJcrConstants { | ||
| int DEFAULT_WARN_LOG_STRING_SIZE_THRESHOLD_VALUE = 102400; |
Contributor
There was a problem hiding this comment.
I don't recall our earlier discussion, but I though we were saying that indexing end (OAK-8642) would log for 100K while jcr side would be a bit more tolerable. But maybe, I'm mis-remembering.
Contributor
Author
There was a problem hiding this comment.
AFAIR, two different values were not suggested. If you think we should have different values, let me know what should be default value for jcr.
Contributor
There was a problem hiding this comment.
Nah... It's just what I recalled. I'm on both ways.
Contributor
Author
|
Changes merged in trunk. Closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.