Skip to content

OAK-12336 : update Postgres database server to 14 - #3064

Merged
rishabhdaim merged 5 commits into
trunkfrom
OAK-12336
Aug 8, 2026
Merged

OAK-12336 : update Postgres database server to 14#3064
rishabhdaim merged 5 commits into
trunkfrom
OAK-12336

Conversation

@rishabhdaim

Copy link
Copy Markdown
Contributor

No description provided.

@rishabhdaim
rishabhdaim requested a review from reschke August 5, 2026 03:36
@rishabhdaim rishabhdaim self-assigned this Aug 5, 2026
@rishabhdaim

Copy link
Copy Markdown
Contributor Author

ITs have passed locally.

cc @reschke

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Commit-Check ✔️

@rishabhdaim

Copy link
Copy Markdown
Contributor Author

Review

P2 · oak-doc/src/site/markdown/testing.md:68 · Testing doc's PostgreSQL Docker example still used postgres:13-alpine, below the new minimum.

RDBDocumentStoreDB.POSTGRES.checkVersion now requires PostgreSQL >= 14.0 (this PR). A developer following the doc's Docker command to stand up a local test database would pull postgres:13-alpine, below the new minimum, and hit the unsupported-version diagnostic at connection time.

Fixed in c6f8069: bumped the Docker image tag/prose to postgres:14-alpine, and added RDBJDBCToolsTest covering RDBJDBCTools.versionCheck and RDBDocumentStoreDB.POSTGRES.checkVersion (including a regression guard for the 13→14 threshold, which had no prior test coverage).

No correctness issues found in the version-check change itself — it only builds a logged diagnostic string and never throws or blocks the connection.

@rishabhdaim

Copy link
Copy Markdown
Contributor Author

Two more findings surfaced by a second, independent PR analysis were verified and addressed in 0d88379:

  • RDBBlobStoreDB.POSTGRES.checkVersion still required only PostgreSQL >= 9.5 while this PR raised the document store minimum to 14.0 — bumped the blob store minimum to 14.0 as well for consistency (driver-version threshold left unchanged).
  • RDBDocumentStore.java logs versionDiags at LOG.error on every startup when the check fails. Raising the minimum here means PostgreSQL 13.x users (previously fine) will now hit that ERROR-level log on every init — advisory only, no functional break, but can trigger monitoring alerts. Added a code comment documenting this so it is not mistaken for a new bug when users start reporting it.

@rishabhdaim
rishabhdaim requested a review from mbaedke August 5, 2026 07:16

@reschke reschke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the new tests are really a distraction. RDB support is dormant.

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

@rishabhdaim
rishabhdaim merged commit 81a2023 into trunk Aug 8, 2026
1 of 2 checks passed
@rishabhdaim
rishabhdaim deleted the OAK-12336 branch August 8, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants