JAMES-3150 Better handle massive deletions as part of BloomFilterGCAl… - #665
Merged
Merged
Conversation
…gorithm Before we were deleting 128 objjects in parrallel. This approach proved to be slow: we took 25 hours for 35M deletions... With this proposed changeset we delete 1000 blobs per requests, 16 in parallel, using a S3 API to delete several objects at once.
Arsnael
approved these changes
Sep 22, 2021
vttranlina
approved these changes
Sep 22, 2021
vttranlina
left a comment
vttranlina
left a comment
Contributor
There was a problem hiding this comment.
With AWS S3, they limit the request rate (throw an exception if too much request in time).
Some other cloud vendors may be the same.
So, I have a bit of thinking here
Contributor
Not sure about how it works exactly but I would expect the S3 java client being used having a retry mechanism for such issue? If not we would have a lot of blobs disappearing I guess not only there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gorithm
Before we were deleting 128 objjects in parrallel.
This approach proved to be slow: we took 25 hours for 35M deletions...
With this proposed changeset we delete 1000 blobs per requests,
16 in parallel, using a S3 API to delete several objects at
once.