JAMES-3196 Avoid MDC costs when not needed - #667
Merged
Conversation
Arsnael
approved these changes
Sep 23, 2021
vttranlina
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we pay the cost of building MDC for each line of the message, which is useless upon copying the content (won't log in the enclosing context).
Significant performance gains can be achieved by only wrapping the final operation in the MDC:
Run locally, to generate the load:
time smtp-source -A -C100 -r 1 -l 500000 -m 5000 -s 20 -d -c -f any@other.com -M other.com -t bob@localhost localhost:25Which sends 5000 emails of 500KB each...
Before it takes 2 min 30, and the SMTP receival goes at the same speed than the dequeuing
After, it takes 1min40, ~1min to enqueue and 40 more seconds so complete the dequeue...