Get rid of deprecated new instance calls

src/components/org/apache/jmeter/visualizers/RequestPanel.java

@@ -63,7 +63,7 @@ public RequestPanel() {
         for (String clazz : classesToAdd) {
             try {
                 // Instantiate requestview classes
-                final RequestView requestView = (RequestView) Class.forName(clazz).newInstance();
+                final RequestView requestView = (RequestView) Class.forName(clazz).getDeclaredConstructor().newInstance();
                 if (rawTab.equals(requestView.getLabel())) {
                     rawObject = requestView; // use later
                 } else {

src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java

@@ -459,7 +459,7 @@ private Component createComboRender() {
         for (String clazz : classesToAdd) {
             try {
                 // Instantiate render classes
-                final ResultRenderer renderer = (ResultRenderer) Class.forName(clazz).newInstance();
+                final ResultRenderer renderer = (ResultRenderer) Class.forName(clazz).getDeclaredConstructor().newInstance();
                 if (textRenderer.equals(renderer.toString())){
                     textObject=renderer;
                 }

src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

@@ -279,7 +279,7 @@ static BackendListenerClient createBackendListenerClientImpl(Class<?> clientClas
             return new ErrorBackendListenerClient();
         }
         try {
-            return (BackendListenerClient) clientClass.newInstance();
+            return (BackendListenerClient) clientClass.getDeclaredConstructor().newInstance();
         } catch (Exception e) {
             log.error("Exception creating: {}", clientClass, e);
             return new ErrorBackendListenerClient();

src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java

@@ -35,6 +35,7 @@
 import javax.swing.JTextField;
 
 import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.jmeter.config.Argument;
 import org.apache.jmeter.config.Arguments;
 import org.apache.jmeter.config.gui.ArgumentsPanel;
@@ -169,49 +170,16 @@ public void actionPerformed(ActionEvent event) {
 
             String newClassName = ((String) classnameCombo.getSelectedItem()).trim();
             try {
-                BackendListenerClient client = (BackendListenerClient) Class.forName(newClassName, true,
-                        Thread.currentThread().getContextClassLoader()).newInstance();
-                BackendListenerClient oldClient = (BackendListenerClient) Class.forName(className, true,
-                        Thread.currentThread().getContextClassLoader()).newInstance();
+                BackendListenerClient client = createBackendListenerClient(newClassName);
+                BackendListenerClient oldClient = createBackendListenerClient(className);
 
                 Arguments currArgs = new Arguments();
                 argsPanel.modifyTestElement(currArgs);
                 Map<String, String> currArgsMap = currArgs.getArgumentsAsMap();
                 Map<String, String> userArgMap = new HashMap<>();
                 userArgMap.putAll(currArgsMap);
-                Arguments newArgs = new Arguments();
-                Arguments defaultArgs = null;
-                try {
-                    defaultArgs = client.getDefaultParameters();
-                    Arguments currentUserArgs = oldClient.getDefaultParameters();
-                    if(currentUserArgs != null) {
-                        userArgMap.keySet().removeAll(currentUserArgs.getArgumentsAsMap().keySet());
-                    }
-                } catch (AbstractMethodError e) {
-                    log.warn("BackendListenerClient doesn't implement "
-                            + "getDefaultParameters.  Default parameters won't "
-                            + "be shown.  Please update your client class: {}", newClassName);
-                }
-
-                if (defaultArgs != null) {
-                    for (JMeterProperty jMeterProperty : defaultArgs.getArguments()) {
-                        Argument arg = (Argument) jMeterProperty.getObjectValue();
-                        String name = arg.getName();
-                        String value = arg.getValue();
-
-                        // If a user has set parameters in one test, and then
-                        // selects a different test which supports the same
-                        // parameters, those parameters should have the same
-                        // values that they did in the original test.
-                        if (currArgsMap.containsKey(name)) {
-                            String newVal = currArgsMap.get(name);
-                            if (newVal != null && newVal.length() > 0) {
-                                value = newVal;
-                            }
-                        }
-                        newArgs.addArgument(name, value);
-                    }
-                }
+                Arguments defaultArgs = extractDefaultArguments(client, userArgMap, oldClient.getDefaultParameters());
+                Arguments newArgs = copyDefaultArguments(currArgsMap, defaultArgs);
                 userArgMap.forEach(newArgs::addArgument);
 
                 className = newClassName;
@@ -222,6 +190,55 @@ public void actionPerformed(ActionEvent event) {
         }
     }
 
+
+    private Arguments copyDefaultArguments(Map<String, String> currArgsMap, Arguments defaultArgs) {
+        Arguments newArgs = new Arguments();
+        if (defaultArgs != null) {
+            for (JMeterProperty jMeterProperty : defaultArgs.getArguments()) {
+                Argument arg = (Argument) jMeterProperty.getObjectValue();
+                String name = arg.getName();
+                String value = arg.getValue();
+
+                // If a user has set parameters in one test, and then
+                // selects a different test which supports the same
+                // parameters, those parameters should have the same
+                // values that they did in the original test.
+                if (currArgsMap.containsKey(name)) {
+                    String newVal = currArgsMap.get(name);
+                    if (StringUtils.isNotBlank(newVal)) {
+                        value = newVal;
+                    }
+                }
+                newArgs.addArgument(name, value);
+            }
+        }
+        return newArgs;
+    }
+
+
+    private Arguments extractDefaultArguments(BackendListenerClient client, Map<String, String> userArgMap,
+            Arguments currentUserArguments) {
+        Arguments defaultArgs = null;
+        try {
+            defaultArgs = client.getDefaultParameters();
+            if(currentUserArguments != null) {
+                userArgMap.keySet().removeAll(currentUserArguments.getArgumentsAsMap().keySet());
+            }
+        } catch (AbstractMethodError e) {
+            log.warn("BackendListenerClient doesn't implement "
+                    + "getDefaultParameters.  Default parameters won't "
+                    + "be shown.  Please update your client class: {}", client.getClass().getName());
+        }
+        return defaultArgs;
+    }
+
+
+    private BackendListenerClient createBackendListenerClient(String newClassName)
+            throws ReflectiveOperationException {
+        return (BackendListenerClient) Class.forName(newClassName, true,
+                Thread.currentThread().getContextClassLoader()).getDeclaredConstructor().newInstance();
+    }
+
     /**
      * Create a panel containing components allowing the user to provide
      * arguments to be passed to the test class instance.

src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteBackendListenerClient.java

@@ -340,7 +340,7 @@ public void setupTest(BackendListenerContext context) throws Exception {
             }
         }
         Class<?> clazz = Class.forName(graphiteMetricsSenderClass);
-        this.graphiteMetricsManager = (GraphiteMetricsSender) clazz.newInstance();
+        this.graphiteMetricsManager = (GraphiteMetricsSender) clazz.getDeclaredConstructor().newInstance();
         graphiteMetricsManager.setup(graphiteHost, graphitePort, rootMetricsPrefix);
         if (useRegexpForSamplersList) {
             pattern = Pattern.compile(samplersList);

src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java

@@ -365,7 +365,7 @@ public void setupTest(BackendListenerContext context) throws Exception {
         userTag = userTagBuilder.toString();
 
         Class<?> clazz = Class.forName(influxdbMetricsSender);
-        this.influxdbMetricsManager = (InfluxdbMetricsSender) clazz.newInstance();
+        this.influxdbMetricsManager = (InfluxdbMetricsSender) clazz.getDeclaredConstructor().newInstance();
         influxdbMetricsManager.setup(influxdbUrl);
         samplersToFilter = Pattern.compile(samplersRegex);
         addAnnotation(true);

src/core/org/apache/jmeter/NewDriver.java

@@ -240,7 +240,7 @@ public static void main(String[] args) {
 
             try {
                 Class<?> initialClass = loader.loadClass("org.apache.jmeter.JMeter");// $NON-NLS-1$
-                Object instance = initialClass.newInstance();
+                Object instance = initialClass.getDeclaredConstructor().newInstance();
                 Method startup = initialClass.getMethod("start", new Class[] { new String[0].getClass() });// $NON-NLS-1$
                 startup.invoke(instance, new Object[] { args });
             } catch(Throwable e){ // NOSONAR We want to log home directory in case of exception

src/core/org/apache/jmeter/engine/util/CompoundVariable.java

@@ -72,7 +72,7 @@ public class CompoundVariable implements Function {
             List<String> classes = ClassFinder.findClassesThatExtend(JMeterUtils.getSearchPaths(),
                     new Class[] { Function.class }, true, contain, notContain);
             for (String clazzName : classes) {
-                Function tempFunc = (Function) Class.forName(clazzName).newInstance();
+                Function tempFunc = (Function) Class.forName(clazzName).getDeclaredConstructor().newInstance();
                 String referenceKey = tempFunc.getReferenceKey();
                 if (referenceKey.length() > 0) { // ignore self
                     functions.put(referenceKey, tempFunc.getClass());
@@ -195,7 +195,7 @@ public void setParameters(String parameters) throws InvalidVariableException {
     static Object getNamedFunction(String functionName) throws InvalidVariableException {
         if (functions.containsKey(functionName)) {
             try {
-                return functions.get(functionName).newInstance();
+                return functions.get(functionName).getDeclaredConstructor().newInstance();
             } catch (Exception e) {
                 log.error("Exception occurred while instantiating a function: {}", functionName, e); // $NON-NLS-1$
                 throw new InvalidVariableException(e);

src/core/org/apache/jmeter/gui/GuiPackage.java

@@ -363,7 +363,7 @@ public TestElement createTestElement(String objClass) {
                     "Missing jar? See log file." ,
                     JOptionPane.ERROR_MESSAGE);
             throw new RuntimeException(e.toString(), e); // Probably a missing jar
-        } catch (ClassNotFoundException | InstantiationException | IllegalAccessException e) {
+        } catch ( ReflectiveOperationException e) {
             log.error("Problem retrieving gui for " + objClass, e);
             throw new RuntimeException(e.toString(), e); // Programming error: bail out.
         }
@@ -389,9 +389,9 @@ public TestElement createTestElement(String objClass) {
      * @throws IllegalAccessException
      *             if access rights do not allow the default constructor to be
      *             called
+     * @throws ReflectiveOperationException when construction of guiClass fails
      */
-    private JMeterGUIComponent getGuiFromCache(Class<?> guiClass, Class<?> testClass) throws InstantiationException,
-            IllegalAccessException {
+    private JMeterGUIComponent getGuiFromCache(Class<?> guiClass, Class<?> testClass) throws ReflectiveOperationException {
         JMeterGUIComponent comp;
         if (guiClass == TestBeanGUI.class) {
             comp = testBeanGUIs.get(testClass);
@@ -402,7 +402,7 @@ private JMeterGUIComponent getGuiFromCache(Class<?> guiClass, Class<?> testClass
         } else {
             comp = guis.get(guiClass);
             if (comp == null) {
-                comp = (JMeterGUIComponent) guiClass.newInstance();
+                comp = (JMeterGUIComponent) guiClass.getDeclaredConstructor().newInstance();
                 if (!(comp instanceof UnsharedComponent)) {
                     guis.put(guiClass, comp);
                 }
@@ -909,7 +909,7 @@ public TreeNodeNamingPolicy getNamingPolicy() {
 
             try {
                 Class<?> implementationClass = Class.forName(namingPolicyImplementation);
-                this.namingPolicy = (TreeNodeNamingPolicy) implementationClass.newInstance();
+                this.namingPolicy = (TreeNodeNamingPolicy) implementationClass.getDeclaredConstructor().newInstance();
 
             } catch (Exception ex) {
                 log.error("Failed to create configured naming policy:" + namingPolicyImplementation + ", will use default one", ex);

src/core/org/apache/jmeter/gui/action/ActionRouter.java

@@ -369,7 +369,7 @@ public void populateCommandMap() {
             }
             for (String strClassName : listClasses) {
                 Class<?> commandClass = Class.forName(strClassName);
-                Command command = (Command) commandClass.newInstance();
+                Command command = (Command) commandClass.getDeclaredConstructor().newInstance();
                 for (String commandName : command.getActionNames()) {
                     Set<Command> commandObjects = commands.computeIfAbsent(commandName, k -> new HashSet<>());
                     commandObjects.add(command);

src/core/org/apache/jmeter/gui/action/AddThinkTimeBetweenEachStep.java

@@ -132,12 +132,13 @@ private void addNodesToTreeHierachically(GuiPackage guiPackage,
      * @param guiPackage {@link GuiPackage}
      * @param parentNode {@link JMeterTreeNode}
      * @return array of {@link JMeterTreeNode}
-     * @throws IllegalUserActionException
+     * @throws ReflectiveOperationException when class instantiation for {@value #DEFAULT_IMPLEMENTATION} fails
+     * @throws IllegalUserActionException when {@link ThinkTimeCreator#createThinkTime(GuiPackage, JMeterTreeNode)} throws this
      */
-    private JMeterTreeNode[] createThinkTime(GuiPackage guiPackage, JMeterTreeNode parentNode) 
-        throws Exception {
+    private JMeterTreeNode[] createThinkTime(GuiPackage guiPackage, JMeterTreeNode parentNode)
+            throws ReflectiveOperationException, IllegalUserActionException  {
         Class<?> clazz = Class.forName(DEFAULT_IMPLEMENTATION);
-        ThinkTimeCreator thinkTimeCreator = (ThinkTimeCreator) clazz.newInstance();
+        ThinkTimeCreator thinkTimeCreator = (ThinkTimeCreator) clazz.getDeclaredConstructor().newInstance();
         return thinkTimeCreator.createThinkTime(guiPackage, parentNode);
     }
 

src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java

@@ -222,7 +222,7 @@ private List<MenuCreator> findMenuCreators() {
                     Class<?> commandClass = Class.forName(strClassName);
                     if (!Modifier.isAbstract(commandClass.getModifiers())) {
                         log.debug("Instantiating: {}", commandClass);
-                        MenuCreator creator = (MenuCreator) commandClass.newInstance();
+                        MenuCreator creator = (MenuCreator) commandClass.getDeclaredConstructor().newInstance();
                         creators.add(creator);
                     }
                 } catch (Exception e) {

src/core/org/apache/jmeter/gui/util/MenuFactory.java

@@ -171,7 +171,7 @@ private static JMeterGUIComponent getGUIComponent(
                         || (testBeanGUI.isExpert() && !JMeterUtils.isExpertMode());
                 item = testBeanGUI;
             } else {
-                item = (JMeterGUIComponent) c.newInstance();
+                item = (JMeterGUIComponent) c.getDeclaredConstructor().newInstance();
             }
         } catch (NoClassDefFoundError e) {
             log.warn("Configuration error, probably corrupt or missing third party library(jar)? Could not create class: {}.",