Fix memory leak in CacheManager by reusing InheritableThreadLocal ins…#6731
Open
rajat315315 wants to merge 1 commit into
Open
Fix memory leak in CacheManager by reusing InheritableThreadLocal ins…#6731rajat315315 wants to merge 1 commit into
rajat315315 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6730
Description
We have resolved the progressive memory leak in
CacheManagerby reusing a singleInheritableThreadLocalinstance and clearing per-thread state via.remove(). All changes have been tested, benchmarked under concurrent load, and committed on a dedicated branch.Motivation and Context
How Has This Been Tested?
Automated Unit Tests
./gradlew :src:protocol:http:test --tests "org.apache.jmeter.protocol.http.control.TestCacheManager*"Output:
Concurrent Benchmark Verification
./gradlew :src:protocol:http:test --tests "org.apache.jmeter.protocol.http.control.TestCacheManagerMemoryLeak"Output:
InheritableThreadLocalobjects left in worker threads.Types of changes
Checklist: