Skip to content

HOTFIX: fix Scala 2.12 build error caused by ControllerApisTest.scala#10146

Merged
ijuma merged 2 commits intoapache:trunkfrom
chia7712:MINOR-10146
Feb 18, 2021
Merged

HOTFIX: fix Scala 2.12 build error caused by ControllerApisTest.scala#10146
ijuma merged 2 commits intoapache:trunkfrom
chia7712:MINOR-10146

Conversation

@chia7712
Copy link
Member

related to #10113

Error Message

14:01:06 > Task :core:compileTestScala 14:01:06 [Error] /home/jenkins/agent/workspace/LoopTest-Kafka/kafka/core/src/test/scala/unit/kafka/server/ControllerApisTest.scala:70: the result type of an implicit conversion must be more specific than Object

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

@cmccabe cmccabe added the kraft label Feb 18, 2021
@cmccabe cmccabe changed the title HOTFIX: fix build error caused by ControllerApisTest.scala HOTFIX: fix Scala 2.12 build error caused by ControllerApisTest.scala Feb 18, 2021
@rondagostino
Copy link
Contributor

Successfully confirmed this fix locally as per comment in #10155.

@ijuma ijuma merged commit 97c9ae1 into apache:trunk Feb 18, 2021
@chia7712
Copy link
Member Author

The 2.8 build with scala 2.12 is broken also so I back port this PR to 2.8

chia7712 added a commit that referenced this pull request Feb 23, 2021
Introduced by #10113. The error was:

```
14:01:06 > Task :core:compileTestScala
14:01:06 [Error] /home/jenkins/agent/workspace/LoopTest-Kafka/kafka/core/src/test/scala/unit/kafka/server/ControllerApisTest.scala:70: the result type of an implicit conversion must be more specific than Object
```

Reviewers: Ismael Juma <ismael@juma.me.uk
@chia7712 chia7712 deleted the MINOR-10146 branch March 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants