Skip to content

MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware#11089

Closed
JoeCqupt wants to merge 1 commit intoapache:trunkfrom
JoeCqupt:MINOR-remove-unnecessary-judgment
Closed

MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware#11089
JoeCqupt wants to merge 1 commit intoapache:trunkfrom
JoeCqupt:MINOR-remove-unnecessary-judgment

Conversation

@JoeCqupt
Copy link
Copy Markdown
Contributor

@JoeCqupt JoeCqupt commented Jul 20, 2021

remove unnecessary judgment in method AdminUtils::assignReplicasToBrokersRackAware
because replicationFactor <= numBrokers , so the judgment is not necessary

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@JoeCqupt JoeCqupt changed the title MINOR: remove unnecessary judgment MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware Jul 21, 2021
@JoeCqupt
Copy link
Copy Markdown
Contributor Author

JoeCqupt commented Jul 22, 2021

call for review @ijuma @guozhangwang @hachikuji @mjsax @ableegoldman

@JoeCqupt JoeCqupt marked this pull request as draft July 22, 2021 11:46
@JoeCqupt JoeCqupt marked this pull request as ready for review July 22, 2021 11:52
@guozhangwang
Copy link
Copy Markdown
Contributor

Overall looks good to me. Just one qq: do we always guarantee replicationFactor <= numBrokers? I know we check and forbid it when creating a new topic, but after a topic is created, if we shutdown brokers and reassign replicas, would we stop with less replicas and warn users?

cc @ijuma for another look.

@JoeCqupt
Copy link
Copy Markdown
Contributor Author

@ijuma

@JoeCqupt JoeCqupt closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants