Skip to content

MINOR: Fix internal topic manager tests#11574

Merged
cadonna merged 1 commit into
apache:trunkfrom
cadonna:fix_internal_topic_manager_tests
Dec 7, 2021
Merged

MINOR: Fix internal topic manager tests#11574
cadonna merged 1 commit into
apache:trunkfrom
cadonna:fix_internal_topic_manager_tests

Conversation

@cadonna
Copy link
Copy Markdown
Member

@cadonna cadonna commented Dec 7, 2021

When the unit tests of the internal topic manager test
are executed on a slow machine (like sometimes in automatic builds)
they sometimes fail with a timeout exception instead of the expected
exception. To fix this behavior, this commit replaces the use of
system time with mock time.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

When the unit tests of the internal topic manager test
are executed on a slow machine (like sometimes in automatic builds)
they sometimes fail with a timeout exception instead of the expected
exception. To fix this behavior, this commit replaces the use of
system time with mock time.
@cadonna cadonna requested review from guozhangwang and mjsax December 7, 2021 13:19
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @cadonna !

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Dec 7, 2021

Test failures are not related.

@cadonna cadonna merged commit 68c3018 into apache:trunk Dec 7, 2021
xdgrulez pushed a commit to xdgrulez/kafka that referenced this pull request Dec 22, 2021
When the unit tests of the internal topic manager test
are executed on a slow machine (like sometimes in automatic builds)
they sometimes fail with a timeout exception instead of the expected
exception. To fix this behavior, this commit replaces the use of
system time with mock time.

Reviewer: John Roesler <vvcephei@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants