Skip to content

MINOR: Log controller id/epoch when LeaderAndIsr, StopReplica and UpdateMetadata requests are fenced#12645

Merged
dajac merged 1 commit into
apache:trunkfrom
dajac:minor-log-controller-id
Sep 20, 2022
Merged

MINOR: Log controller id/epoch when LeaderAndIsr, StopReplica and UpdateMetadata requests are fenced#12645
dajac merged 1 commit into
apache:trunkfrom
dajac:minor-log-controller-id

Conversation

@dajac
Copy link
Copy Markdown
Member

@dajac dajac commented Sep 15, 2022

Logging the controller id and its epoch is useful in those messages. It helps identifying where they come from.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Agree it's helpful to add these logs.

@dajac
Copy link
Copy Markdown
Member Author

dajac commented Sep 15, 2022

Thanks @showuon. I will merge it when the builds complete.

@dajac dajac merged commit ff4c4d1 into apache:trunk Sep 20, 2022
@dajac dajac deleted the minor-log-controller-id branch September 20, 2022 13:26
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
…ateMetadata requests are fenced (apache#12645)

Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants