MINOR: Remove unnecessary scalac warnings suppression #12953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the underlying warnings instead.
showuon
reviewed
Dec 5, 2022
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
LGTM! Let's see if the jenkins build passed.
showuon
approved these changes
Dec 5, 2022
SoulPancake
approved these changes
Dec 5, 2022
Member
Author
|
JDK 11 and 17 passed, JDK 8 had 4 unrelated failures:
|
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
Fix the underlying warnings instead. Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the underlying warnings instead.
Committer Checklist (excluded from commit message)