KAFKA-16724: Added support for fractional throughput and monotonic payload in kafka-producer-perf-test.sh#16238
Merged
omkreddy merged 1 commit intoapache:trunkfrom Jun 11, 2024
Merged
Conversation
AndrewJSchofield
approved these changes
Jun 7, 2024
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
The code looks good to me. The build did not complete after 8 hours, and it's probably prudent to see build output before merging, although this should be a very low risk change indeed.
omkreddy
approved these changes
Jun 11, 2024
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
@ShivsundarR Thanks for the PR. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added support for fractional throughput and monotonic payload in kafka-producer-perf-test.sh.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-932%3A+Queues+for+Kafka#KIP932:QueuesforKafka-kafka-producer-perf-test.sh