MINOR: add log4j2.yaml to clients-integration-tests module #19252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
approved these changes
Mar 20, 2025
chia7712
reviewed
Mar 20, 2025
|
|
||
| Loggers: | ||
| Root: | ||
| level: ALL |
Member
There was a problem hiding this comment.
maybe INFO is good enough. WDYT?
Collaborator
Author
There was a problem hiding this comment.
Sure, addressed it.
frankvicky
reviewed
Mar 21, 2025
Contributor
frankvicky
left a comment
frankvicky
left a comment
There was a problem hiding this comment.
@m1a2st : Thanks for the patch.
| PatternLayout: | ||
| pattern: "${logPattern}" | ||
|
|
||
| Loggers: |
Contributor
There was a problem hiding this comment.
Do we need the logger org.apache.kafka just like the client module?
Member
There was a problem hiding this comment.
The log will be too large if we use INFO level. Could you please use the following levels (same as core)
Loggers:
Root:
level: OFF
AppenderRef:
- ref: STDOUT
Logger:
- name: kafka
level: WARN
- name: org.apache.kafka
level: WARN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clients-integration-testsmodules doesn't have thelog4j2.yamlto setting log, thus we should add.Reviewers: TengYao Chi kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com