Skip to content

Conversation

@chickenchickenlove
Copy link
Contributor

Description

  • Related Issue - https://issues.apache.org/jira/browse/KAFKA-19393
    Currently, Both SubscriptionState and AbstractMembershipManager have states related with Assignment as their member fields.
    So, it can be confusing point because which one is source of truth.
    Therefore, It would be better to consolidate consumer assignment state views.

Discussion Points.

In this PR, AbstractMembershipManager has still currentAssignments and currentTargetAssignments.
The LocalAssignment includes information of assignment and information of protocol between consumer - broker.
So, I'm not sure that AssignState or SubscriptionState knows information of protocol between consumer - broker.

So, apart from that, I’ve extracted all the remaining assignment-related data into AssignState.
In addition to, IMHO, Also, since AssignState is a subdomain of Subscription in terms of meaning, it has been extracted as an internal state within Subscription.

I made a commit based on my thoughts!
It would like to hear feedback from others.

Please take a look, @lianetm and other reviewer 🙇‍♂️

@github-actions github-actions bot added triage PRs from the community consumer clients labels Nov 12, 2025
@chickenchickenlove
Copy link
Contributor Author

chickenchickenlove commented Nov 16, 2025

@lianetm Hi!
Sorry to bother you.
I made a Draft PR and I want to discuss with you about extracting AssingState from MembershipManager.
When you have time, could you give me your opinion about Discussion Points in PR descriptions? 🙇‍♂️

@lianetm
Copy link
Member

lianetm commented Nov 17, 2025

Hey @chickenchickenlove , thanks for starting this! Sure, I will take a look. Very busy now with the 4.2 deadlines starting this week, but will come back to this one asap.

@github-actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants