KAFKA-19845: 2/N Additional share consumers tests. #20900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
smjn
added
KIP-932
smjn
changed the title
smjn
changed the title
AndrewJSchofield
approved these changes
Nov 18, 2025
| } | ||
|
|
||
| private void verifyYammerMetricCount(String filterString, int count) { | ||
| com.yammer.metrics.core.Metric renewAck = KafkaYammerMetrics.defaultRegistry().allMetrics().entrySet().stream() |
Member
There was a problem hiding this comment.
nit: This isn't really a renewAck because the filter string is an argument. However, that's such a tiny nit that we can fix it next time through this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renew and poll behavior with renew acks piggybacked.
Reviewers: Andrew Schofield aschofield@confluent.io