Skip to content

KAFKA-19888: Clamp negative values in coordinator histograms #20986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

KAFKA-19888: Clamp negative values in coordinator histograms #20986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...inator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/HdrHistogram.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ private Histogram latestHistogram(long now) {
}

/**
* Writes to the histogram. Caps recording to highestTrackableValue
* Writes to the histogram. Caps recording between 0 and highestTrackableValue.
*
* @param value The value to be recorded. Cannot be negative.
* @param value The value to be recorded.
*/
public void record(long value) {
recorder.recordValue(Math.min(value, highestTrackableValue));
recorder.recordValue(Math.min(Math.max(value, 0), highestTrackableValue));
}

/**
Expand Down
6 changes: 5 additions & 1 deletion ...or-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,14 @@ public void testLatestHistogramRace() throws InterruptedException, ExecutionExce

@Test
public void testRecordLimit() {
long now = System.currentTimeMillis();
long highestTrackableValue = 10L;
HdrHistogram hdrHistogram = new HdrHistogram(10L, highestTrackableValue, 3);

hdrHistogram.record(highestTrackableValue + 1000L);
assertEquals(highestTrackableValue, hdrHistogram.max(System.currentTimeMillis()));
assertEquals(highestTrackableValue, hdrHistogram.max(now));

hdrHistogram.record(-50L);
assertEquals(0, hdrHistogram.max(now + 1000L));
Copy link
Contributor Author

@squah-confluent squah-confluent Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no histogram min method. We can add one, but it'd be only used in this one test.

}
}