-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-19951: Update lz4 dependency version for CVE-2025-12183 #21035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Updated lz4 dependency version from 1.8.0 to 1.8.1. For https://nvd.nist.gov/vuln/detail/CVE-2025-12183
|
Thanks for the patch. Could you also update |
|
@DL1231 thank you, updated license binary, do you know how |
|
I linked the PR to KAFKA-19951. Regarding the compression level, it's explained in |
|
Also there's still a build issue: |
It looks like there was a recent change to discontinue https://github.com/lz4/lz4-java, in favor of community fork https://github.com/yawkat/lz4-java . I'll try updating to new GAV |
|
Maintainer here. Interesting, did you see that error when depending on org.lz4:lz4-java:1.8.1 directly, without any reference to at.yawk.lz4? Maybe there's something wrong with the gradle capability metadata |
|
Looks like max compression level is unchanged at |
Yeah, had to switch to your gav for it to work (I'm just a random person not affil with apache): 51c520e |
Simple example demonstrating the issue mentioned by @mimaison: If only There might be an issue with the capability configuration together with the relocation settings, which could be the reason for the problem. |
|
@mjschwaiger I made a test case here: https://github.com/yawkat/test-case-gradle-rename-capability I think it's a gradle bug, I've asked on the gradle community slack about it. |
chia7712
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mimaison do you have time to take a look at this? |
|
BTW: If the Java project is discontinued, I think it would be a good idea to get rid of the library. Not sure where I could raise this question as an issue. |
I recommend KAFKA-17301 for raising this issue 😄 |
gradle/dependencies.gradle
Outdated
| lz4: "1.8.0", | ||
| // https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/record/CompressionType.java#L73-L74 | ||
| // https://github.com/yawkat/lz4-java/blob/main/src/java/net/jpountz/lz4/LZ4Constants.java#L23-L24 | ||
| lz4: "1.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we directly bump to 1.10.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done (cd8be9e)
org.lz4:lz4-java is not maintained but at.yawk.lz4:lz4-java is a new fork that is maintained. |
DL1231
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the patch.
|
Really looking forward to this team!. We have many services using this library and the "CVE alerts" already raised. Thanks for the great job! |
|
@erikanderson sorry for intervening on your PR, but we have two planned releases waiting for this patch 😃 |
Updated lz4 dependency version from 1.8.0 to 1.8.1. For
https://nvd.nist.gov/vuln/detail/CVE-2025-12183
See https://github.com/yawkat/lz4-java/releases/tag/v1.8.1
Reviewers: Gaurav Narula gaurav_narula2@apple.com, Lan Ding
isDing_L@163.com, Chia-Ping Tsai chia7712@gmail.com