MINOR: Require non-null arguments to GroupCoordinatorService#onMetadataUpdate #21052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems we need updates in |
Member
Author
@lianetm Fixed it. |
chia7712
approved these changes
Dec 3, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
LGTM, with one trivial comment left
| @Test | ||
| public void testKRaftCoordinatorDeltaWithNulls() { | ||
| assertTrue(new KRaftCoordinatorMetadataDelta(null).changedTopicIds().isEmpty()); | ||
| assertTrue(new KRaftCoordinatorMetadataDelta(new MetadataDelta(MetadataImage.EMPTY)).changedTopicIds().isEmpty()); |
Member
There was a problem hiding this comment.
Excuse me, why to remove other test cases?
Member
Author
There was a problem hiding this comment.
All the tests taking null are irrelevant now and I found the others weird as they are not really related to testing the null case too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some tests passing null values to
GroupCoordinatorService#onMetadataUpdateeven though it is not anexpected case. This patch fixes those tests and ensure that only
non-null values are accepted.
Reviewers: Lianet Magrans lmagrans@confluent.io, Sean Quah
squah@confluent.io, Chia-Ping Tsai chia7712@gmail.com