KAFKA-19439; OffsetFetch API does not return group level errors correctly with version 1 for 3.9 #21063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly with version 1 The OffsetFetch API does not support top level errors in version 1. Hence, the top level error must be returned at the partition level. Side note: It is a tad annoying that we create error response in multiple places (e.g. KafkaApis, Group CoordinatorService). There were a reason for this but I cannot remember. Reviewers: Dongnuo Lyu <dlyu@confluent.io>, Sean Quah <squah@confluent.io>, Ken Huang <s7133700@gmail.com>, TengYao Chi <frankvicky@apache.org>
FrankYang0529
approved these changes
Dec 3, 2025
Member
FrankYang0529
left a comment
FrankYang0529
left a comment
There was a problem hiding this comment.
I cannot reproduce failed test cases in my environment with different JDK version 8, 21, 23.
chia7712
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OffsetFetch API does not support top level errors in version 1. Hence, the top level error must be returned at the partition level.
Side note: It is a tad annoying that we create error response in multiple places (e.g. KafkaApis, Group CoordinatorService). There were a reason for this but I cannot remember.
Reviewers: PoAn Yang payang@apache.org, Dongnuo Lyu dlyu@confluent.io, Sean Quah squah@confluent.io, Ken Huang s7133700@gmail.com, TengYao Chi kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com